Skip to content

grpc: 1.41.0 -> 1.42.0#146580

Merged
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc
Nov 19, 2021
Merged

grpc: 1.41.0 -> 1.42.0#146580
marsam merged 2 commits intoNixOS:masterfrom
marsam:update-grpc

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Nov 19, 2021

Motivation for this change

https://github.com/grpc/grpc/releases/tag/v1.42.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 19, 2021
@marsam
Copy link
Contributor Author

marsam commented Nov 19, 2021

@GrahamcOfBorg build murmur bear
@GrahamcOfBorg build sysdig libtensorflow

@ofborg ofborg bot requested a review from LnL7 November 19, 2021 05:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Nov 19, 2021
@marsam marsam merged commit 8f77f1b into NixOS:master Nov 19, 2021
@marsam marsam deleted the update-grpc branch November 19, 2021 12:52
@vcunat
Copy link
Member

vcunat commented Nov 19, 2021 •
edited
Loading

FYI, this apparently broke build on aarch64-linux: https://hydra.nixos.org/log/1wk57s15jqb7grx237lk3v56qmninxcp-grpc-1.42.0.drv

EDIT: I see the OfBorg CI also found the same error.

@marsam marsam mentioned this pull request Nov 20, 2021
Merged
13 tasks
@marsam
Copy link
Contributor Author

marsam commented Nov 20, 2021

Sorry about that. Fixed in #146720

@marsam marsam mentioned this pull request Aug 6, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marsam @vcunat